1.13 update status thread

[bigpresh]

Hola,

This thread will be used for status updates on the update to 1.13, so feel free to subscribe to updates to it.

I had a quick look tonight with a view to testing out 1.13 on my test server, but SpigotMC.org recommends against upgrading to it for existing worlds, warning "There are still known issues in Vanilla which can cause item loss in chest blocks."

So, it sounds like it's not a good time to consider upgrading yet, and we should wait until things are likely to be smoother, rather than people losing items as part of the upgrade - I can't see that being popular

The item loss seems to be down to MC-134115: https://bugs.mojang.com/browse/MC-134115 - affecting double-chests which happen to sit across a chunk boundary, causing them to lose half their contents.

So, I'll watch for that to be fixed first before we do anything about upgrading I think - don't want anyone losing loads of items.

[bigpresh]

Still waiting for it to be safe to upgrade.

https://bugs.mojang.com/browse/MC-134205 is resolved as a duplicate.

https://bugs.mojang.com/browse/MC-134115 is reopened as still happening, but at least contains a fix 4 days ago done in Paper, and supplied to Dinnerbone & Grum, so hopefully will be fixed in MC itself soon?

The last post by SpigotMC.org still suggests it's unsafe to upgrade a pre-1.13 world to 1.13, so I shall hold off until either MC itself gets a fix, or Spigot implement the fix that Paper added, and then do some tests.

[bigpresh]

1.13.1 is now seeming more stable, and Spigot no longer recommend strongly against using it with existing worlds.

I have a test server spun up alongside the live server, with a copy of our live world, to see how things go.

Blockers so far:

Logblock doesn't work under 1.13 -there's https://github.com/LogBlock/LogBlock/releases which I think is the same plugin and reports 1.13 support, will investigate

Dynmap - the version we used doesn't work, but v3.0-beta-1 should do

Once we're happy the plugins we rely on are working, we can do some more testing, and ensure that all is working as we'd expect it to be, that the world converted correctly, that nothing is missing/broken etc, then consider switching over.

[bigpresh]

I've got LogBlock and Dynmap working on it now, but it seems to be struggling with chunk generation or something. I teleported out to 70k, ~, 70k and now the test server wedges whenever I try to log in.

[bigpresh]

So far, seem to have narrowed down the problems we're seeing to something to do with one of the plugins we run, and, seemingly, mostly/only happening when pre-1.13 chunks are being loaded & converted.

I've ruled out the most obvious plugins:
Dynmap
GriefPrevention
ProtocolLib

I've also tested with *all* plugins disabled, and all seemed well, so it seems to suggest that it's one of the several plugins we run which I haven't yet ruled out. (It's a somewhat slow and tedious process.)

I'll continue to test with one plugin at a time removed to see if I can narrow it down to a culprit without which the problem doesn't happen, but at the moment, things are nowhere near stable enough to consider upgrading.

[bigpresh]

Getting mildly closer, with the release of 1.13.2 and some updated plugins, but still performance issues, NoCheatPlus triggering wrongly, rubberbanding etc, and crashes etc, so we'll still hold off a bit longer yet.

Thanks for those who hopped on to help test tonight!

[bigpresh]

Well, still not on 1.13 - but looking closer.

Tried a later build of PaperMC today - still having crashy problems.

Compiled and tried the latest Spigot build this evening, took a couple of attempts to connect (client hanging at "Encrypting", then at "Loading terrain") but after that, seemed pretty damn solid.

Please feel free to help test again - connect to slideaway.preshweb.co.uk:25566 - and see if all seems OK for you. If all is still looking good, we could go for an upgrade soon. I will probably play it safe and have a few hours of downtime to take a full snapshot backup of the world right before upgrading, so we could roll back if things didn't go smoothly.

Definitely want to get us on 1.13 ASAP though, might get some more interest and players returning hopefully!

[bigpresh]

RIGHT - things are, finally, looking better for the 1.13 upgrade.

Tonight I've put the most recent Spigot build, 1993, on the test server; so far it appears to play well.

I've installed Phonix Anti-Cheat in place of NoCheatPlus which still hasn't been upgraded to 1.13, and it looks promising - not false triggering on any of the usual suspect blocks except for cake blocks - so, don't walk on cakes. (I haven't yet tested turtle egg blocks actually, should check that).

So, I need to run through some final tests - making sure the portals all still work, etc, testing GriefPrevention is still behaving although it was when I first tested it in 1.13, and a few other bits.

Please feel free to help test - the test server is slideaway.preshweb.co.uk:25566 - test that your area loads right (i.e. chunk loading & conversion hasn't done anything stupid) and that everything is as you'd expect it to be) and let me know if you see anything odd!

[bigpresh]

Right, another update.

I've swapped NoCheatPlus (which wasn't updated for 1.13) for Phoenix Anti-Cheat, with acceptable results.

I've swapped Multiverse Portals for Advanced Portals, which is working in 1.13 and seems slightly easier to configure and a bit lighter on resources too.

We're at a point where nearly everything is working, so here's the checklist of stuff I'd like to double-check before upgrading, and also run through again after the upgrade:

* Grief Prevention - make sure that expected protections apply, e.g.:
- actions blocked in other peoples claim without trust: placing/breaking blocks, accessing chests, hurting animals etc
- can use claim visualisations, can create / resize claims

* Phoenix Anti-Cheat - no false detections on stairs / slabs / new 1.13 stuff (try the new effects, riptide etc, rising/falling water, trident throws etc)

* Dynmap updates (renders new/changed chunks)

* Our custom code:
- auto minecarts
- PvP protection (check trident damage blocked in particular)

* Logblock - can look up previous data, new data is recorded

I *think* the issues I was seeing with chunk loading/conversion are solved - things have been pretty stable - but the lack of having multiple people testing at one time limits the proper stress-testing opportunities, so we'll see.